Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cleanup and formatting #57

Merged
merged 2 commits into from
Jan 10, 2020
Merged

chore: cleanup and formatting #57

merged 2 commits into from
Jan 10, 2020

Conversation

sleepdefic1t
Copy link
Contributor

Summary

This PR proposed the following:

  • updated all license info.
    • team-made code: ARK MIT license headers.
    • Ledger-like code: ARK MIT + Apache 2.0 license headers.
    • add Ledger Apache 2.0 info the main LICENSE file.
  • remove whitespace/empty lines.
  • updated all “unimplemented” tx type examples.
  • split resources and installation from README into separate doc files.
  • update PAYLOADS doc.
  • update main README.
  • rename ./provision -> ./scripts.
  • move remaining scripts to ./scripts.
  • move icons to ./icons folder.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@sleepdefic1t
chore: cleanup and formatting
e49cb33 
- updated all license info.
    - team-made code: ARK MIT license headers.
    - Ledger-like code: ARK MIT + Apache 2.0 license headers.
    - add Ledger Apache 2.0 info the main LICENSE file.
- remove whitespace/empty lines.
- updated all “unimplemented” tx type examples.
- split resources and installation into separate doc files.
- update PAYLOADS doc.
- update main README.
- rename `./provision` -> `./scripts`.
- move remaining scripts to `./scripts`.
- move icons to `./icons` folder.
@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks. labels Jan 9, 2020
@sleepdefic1t
chore: update unsupported comments and docs
2b43200 
- rename `unimplemented` docs -> `unsupported`
- update main README with a link the the `unsupported` docs.
- add more information about what types aren't supported and why in code comments and in `unsupported` docs.
@sleepdefic1t sleepdefic1t merged commit 79dc76f into ArkEcosystem:develop Jan 10, 2020
@sleepdefic1t sleepdefic1t deleted the chore/formatting-and-cleanup branch January 10, 2020 22:01
@ghost ghost mentioned this pull request Jan 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sleepdefic1t